search

turnerlabs / terraform-ecs-fargate

A Terraform template used for provisioning web application stacks on AWS ECS Fargate
Apache License 2.0
425 stars 158 forks source link

nodejs8.10 lambda is deprecated #41

Closed yzhanggithub closed 4 years ago

yzhanggithub commented 4 years ago

Deprecation of creating nodejs8.10 lambda is Jan 6, 2020 and updating is Feb 3, 2020. https://docs.aws.amazon.com/lambda/latest/dg/runtime-support-policy.html

It was a simple lambda and we just need to update the runtime in ecs-event-stream.tf file. I tested in an app bootstrapped from fargate-create.

I did a PR for terraform-ecs-fargate-nlb (python3 and nodejs10.x), not sure if that's the right repo. There are a few fargate repos which contain logz lambdas and a nodejs8.10 lambda, are the files kept in sync in some way or are they updated separately?

jritsema commented 4 years ago

Thanks for the PR. Yes, would you mind replicating for this repo as well? Also, ideally it's separated into two different PRs. One for the logzio change and the other for the dashboard node version. Thanks!