search

turnerlabs / terraform-ecs-fargate

A Terraform template used for provisioning web application stacks on AWS ECS Fargate
Apache License 2.0
425 stars 158 forks source link

Add secretsmanager #5

Closed jhodnett2 closed 6 years ago

jhodnett2 commented 6 years ago

This creates the secrets manager secret.

The upload script is in the harbor-barge-api.

jritsema commented 6 years ago

We should probably be creating a KMS CMK.

https://www.terraform.io/docs/providers/aws/r/secretsmanager_secret.html#kms_key_id

jhodnett2 commented 6 years ago

I missed the conversation about the KMS Key. I could easily add one. Its a dollar per key (not that its that much) plus $0.03 per 10000 requests... Just data.

Is this still a desire?