search

turnermm / abortlogin

Allow login to Dokuwiki from known IP's only
https://www.dokuwiki.org/plugin:abortlogin
GNU General Public License v2.0
2 stars 3 forks source link

option to have abortadmin only #7

Open jmchantrein opened 1 year ago

jmchantrein commented 1 year ago

That's a very handy plugin, thank you. An interesting feature would be to apply restrictions only on the admin page and not on the login page. If you think it's easily achievable, I might look into it and make a pull request. What do you think?

turnermm commented 1 year ago

That's different. It's not a login issue. It's an access that comes after a successful login and could be handled with ACL. Unless I misunderstood.

jmchantrein commented 1 year ago

Thank you for your reply. The ACLs don't allow for IP-based filtering like your plugin does. I imagined it might be possible to start from the filtering rules of your plugin to also or only filter access to admin pages, but you're right, it's not the same topic and it's not a login issue. Admin pages are not located behind a path like /admin, it's also not possible to do IP filtering via a reverse proxy on a PathPrefix rule. But on second thought, perhaps it would be possible to modify your plugin to be able to filter logins for a specific subset of logins (for example, those of administrators) but not for all ?