search

turnermm / epub

Dokuwiki plugin for creating ebooks
http://www.dokuwiki.org/plugin:epub
15 stars 9 forks source link

"Warning: Declaration of renderer_plugin_epub::header ..." and "Warning: Cannot modify header information" #36

Closed eduardomozart closed 1 year ago

eduardomozart commented 1 year ago

Hello,

After upgrading to DokuWiki Release 2022-07-31 "Igor", I'd started receiving the following error when I access the built-in DokuWiki's Configuration Manager:

Warning: Declaration of renderer_plugin_epub::header($text, $level, $pos) should be compatible with Doku_Renderer_xhtml::header($text, $level, $pos, $returnonly = false) in /home/eduardo/public_html/wiki/lib/plugins/epub/renderer.php on line 94

Warning: Cannot modify header information - headers already sent by (output started at /home/eduardo/public_html/wiki/lib/plugins/epub/renderer.php:473) in /home/eduardo/public_html/wiki/inc/actions.php on line 38

The issue persists after upgrading to DokuWiki Release 2022-07-31a "Igor".

Please let me know if anymore information are needed to troubleshoot this issue.

eduardomozart commented 1 year ago

It seems that you're already concerned about this issue because you'd commited the https://github.com/turnermm/epub/commit/2f8ebb0e9b1dcbd2a3340d401b2e413e4390e298 fix that I can confirm that fixes the issue, but the plugin wasn't updated into the DokuWiki Plugins page - https://www.dokuwiki.org/plugin:epub

turnermm commented 1 year ago

Thanks. I'll try to get to it tomorrow

turnermm commented 1 year ago

Done. I got to it tonight

eduardomozart commented 1 year ago

I can confirm that the plugin was updated at the DokuWiki plugin page and the updated version is already available for installing at Extension Manager and it's working just fine. Thank you for your good working at this extension @turnermm!