Add CSV/TSV Format Checker To Demo

turnerniles / react-virtualized-pivot

React Virtualized Pivot

https://turnerniles.github.io/react-virtualized-pivot/

MIT License

107 stars 19 forks source link

Add CSV/TSV Format Checker To Demo #106

Closed scottcarol closed 4 years ago

scottcarol commented 6 years ago

Great project - thanks.

When a user is first accessing the demo, they may not understand that the "Choose File" button is for a CSV/TSV file with headers.

What do you think of a pull request for the following changes?

Change wording of button on demo page from "Choose File" to "Upload CSV/TSV File"
Once CSV/TSV file is uploaded, preview the first row and confirm with user that these are the headers. If not, user can add headers and this will be added to the data as first row.

pat310 commented 6 years ago

@niles 👆

scottcarol commented 6 years ago

Hey @pat310 - did you mean to flag for @turnerniles?

pat310 commented 6 years ago

Whoops, yup! Thanks

On Feb 27, 2018, at 12:48, Carol A. Scott notifications@github.com wrote:

Hey @patt310 - did you mean to flag for @turnerniles?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

turnerniles commented 6 years ago

@scottcarol @pat310 We would definitely accept a PR for that! Let me know if you have any questions. It's a great a idea.

scottcarol commented 6 years ago

@turnerniles @pat310 Awesome! I'll ping this thread when I have a PR for your review.