Demo Update - Allow User To Preview, Add And Edit CSV/TSV File Headers

scottcarol commented 6 years ago

This pull request addresses #106 and adds functionality and testing to the Demo. The goal is to help new users successfully use the pivot table by letting them preview the headers of their uploaded files, edit those headers if desired, and add headers if their CSV/TSV file did not include them.

Specific functionality added:

File upload now limited to CSV/TSV (previous file upload allowed all file extensions)
If "Use Sample Dataset" is toggled and a file is uploaded, user sees previews of headers
User can edit those uploaded headers by clicking "Edit Headers" button
User can add a header row by clicking "Oops, I Need To Add My Headers!" button
Validation does not allow a user to add an empty header row
Unit testing added in app.spec.js

Notes on changes:

In package.json, added Toggle-Display library for conditional display
In package.json, added .css to the list of extensions mocked in unit testing
In package.json, changed `enzyme-adapter-react-16' from "^1.1.0" to "1.1.0" because a newer version was causing errors in 'Drawer.spec.js'

turnerniles commented 6 years ago

@scottcarol this looks awesome and thank you! I will take a look at it this week and review / give feedback or merge in depending! I was away this weekend so I didn't have the chance.

scottcarol commented 6 years ago

Awesome @turnerniles definitely open to feedback!

turnerniles commented 6 years ago

@scottcarol This is super cool! Wow! It's great to have the option to edit the headers or add a new header. 👍. I left you some comments that I think should be fairly quick to change and then we can merge. Let me know if you have any comments/questions. I will be quicker to respond this week.

scottcarol commented 6 years ago

Great feedback @turnerniles. I combined addHeaders and saveEditedHeaders into a new function called saveNewHeaders and moved the form validation there as well. Test also updated.

turnerniles commented 6 years ago

@scottcarol Amazing!! Thank you! Merging now.

turnerniles commented 6 years ago

Closed in @scottcarol's #107. @scottcarol thank you again!

scottcarol commented 6 years ago

@turnerniles Happy to help, thanks for creating this great library.

turnerniles / react-virtualized-pivot

Demo Update - Allow User To Preview, Add And Edit CSV/TSV File Headers #107