search

turnitin / moodle-mod_turnitintooltwo

Turnitin Direct plugin (version 2) for Moodle
http://www.turnitin.com
32 stars 63 forks source link

Bug: update_record_raw error when "Auto Generate Lastname" is "Yes" and value of "Student Pseudo Last Name" is empty. #709

Open TomoTsuyuki opened 5 months ago

TomoTsuyuki commented 5 months ago

When "Auto Generate Lastname" is "Yes", and value of "Student Pseudo Last Name" is empty, then showing error below:

Coding error detected, it must be fixed by a programmer: moodle_database::update_record_raw() id field must be specified.

Error
Debug info:
Error code: codingerror

Error
Stack trace:
line 1317 of /lib/dml/pgsql_native_moodle_database.php: coding_exception thrown
line 1374 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->update_record_raw()
line 161 of /mod/turnitintooltwo/turnitintooltwo_user.class.php: call to pgsql_native_moodle_database->update_record()
line 259 of /mod/turnitintooltwo/turnitintooltwo_user.class.php: call to turnitintooltwo_user->get_pseudo_lastname()
line 195 of /mod/turnitintooltwo/turnitintooltwo_user.class.php: call to turnitintooltwo_user->create_tii_user()
line 49 of /mod/turnitintooltwo/turnitintooltwo_user.class.php: call to turnitintooltwo_user->get_tii_user_id()
line 659 of /mod/turnitintooltwo/view.php: call to turnitintooltwo_user->__construct()

It looks there is a bug in mod/turnitintooltwo/turnitintooltwo_user.class.php https://github.com/turnitin/moodle-mod_turnitintooltwo/blob/1e91c649d0bc8939fa2de53701c8f3a1f9d4b748/turnitintooltwo_user.class.php#L161