Open ctam opened 1 month ago
In Moodle 4.3, this plugin (v2024032901) causes a core unit test failure as follows:
Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ -Array &0 () +Array &0 ( + 'modsettingturnitintooltwo' => '-->New settings - Turnitin Assignment 2\n +<fieldset class="adminsettings">\n +<div class="clearer"><!-- --></div>\n +<div class="form-item row" id="admin-accountid">\n + <div class="form-label col-sm-3 text-sm-right">\n + <label for="id_s_turnitintooltwo_accountid">\n + Turnitin Account ID\n + </label>\n + <span class="form-shortname d-block small text-muted">turnitintooltwo | accountid</span>\n + </div>\n + <div class="form-setting col-sm-9">\n + <div class="form-text defaultsnext">\n + <input type="text" name="s_turnitintooltwo_accountid" value="" size="30" id="id_s_turnitintooltwo_accountid" class="form-control text-ltr" >\n +</div>\n + <div class="form-defaultinfo text-muted text-ltr">Default: Empty</div>\n + <div class="form-description mt-3"><p><b>[Required]</b><br />Enter your Turnitin Primary Account ID</p>\n +</div>\n + \n + </div>\n +</div><div class="clearer"><!-- --></div>\n +<div class="form-item row" id="admin-secretkey">\n + <div class="form-label col-sm-3 text-sm-right">\n + <label for="id_s_turnitintooltwo_secretkey">\n + Turnitin Shared Key\n + </label>\n + <span class="form-shortname d-block small text-muted">turnitintooltwo | secretkey</span>\n + </div>\n + <div class="form-setting col-sm-9">\n + <div class="form-password">\n + <span data-passwordunmask="wrapper" data-passwordunmaskid="id_s_turnitintooltwo_secretkey">\n + <span data-passwordunmask="editor">\n + <input type="password"\n + autocomplete="new-password"\n + name="s_turnitintooltwo_secretkey"\n + id="id_s_turnitintooltwo_secretkey"\n + value=""\n + data-size="30"\n + class="form-control d-none"\n + >\n + </span>\n + <a href="#" data-passwordunmask="edit" title="">\n + <span data-passwordunmask="displayvalue"><span>\n +\n +<em>Click to enter text</em>\n +</span>\n +</span>\n + <i class="icon fa fa-pencil fa-fw " title="Edit password" role="img" aria-label="Edit password"></i>\n + </a>\n + <a href="#" data-passwordunmask="unmask" title="">\n + <i class="icon fa fa-eye fa-fw " title="Reveal" role="img" aria-label="Reveal"></i>\n + </a>\n + <span data-passwordunmask="instructions" class="form-text text-muted" style="display: none;">\n + Press enter to save changes\n + </span>\n + </span>\n +</div>\n + <div class="form-description mt-3"><p><b>[Required]</b><br />Enter your Turnitin Shared Key<br /><i>(Set by your Turnitin Administrator)</i></p>\n +</div>\n + \n + </div>\n +</div><div class="clearer"><!-- --></div>\n +<div class="form-item row" id="admin-apiurl">\n + <div class="form-label col-sm-3 text-sm-right">\n + <label for="id_s_turnitintooltwo_apiurl">\n + Turnitin API URL\n + </label>\n + <span class="form-shortname d-block small text-muted">turnitintooltwo | apiurl</span>\n + </div>\n + <div class="form-setting col-sm-9">\n + <div class="form-select defaultsnext">\n + <select id="id_s_turnitintooltwo_apiurl" name="s_turnitintooltwo_apiurl" class="custom-select">\n + <option value="https://api.turnitin.com/" >https://api.turnitin.com/</option>\n + <option value="https://api.turnitinuk.com/" >https://api.turnitinuk.com/</option>\n + <option value="https://sandbox.turnitin.com/" >https://sandbox.turnitin.com/</option>\n + </select>\n +</div>\n + <div class="form-description mt-3"><p><b>[Required]</b><br />Select a Turnitin API URL</p>\n +\n +<div class="test_connection" style="display: none;"><div id="test_link" class="box py-3 "><img class="icon " alt="Test Turnitin Connection" title="Test Turnitin Connection" src="https://www.example.com/moodle/theme/image.php/boost/mod_turnitintooltwo/1/globe" /> <span>Test Turnitin Connection</span></div><div id="testing_container" class="box py-3 "><img class="icon " alt="Testing Connection to Turnitin" title="Testing Connection to Turnitin" src="https://www.example.com/moodle/theme/image.php/boost/mod_turnitintooltwo/1/loader" /> <span>Testing Connection to Turnitin</span></div><div id="test_result" class="box py-3 "></div></div>\n +</div>\n + \n + </div>\n +</div></fieldset>' +) /home/runner/work/moodle/moodle/lib/tests/adminlib_test.php:151 /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:81
In Moodle 4.3, this plugin (v2024032901) causes a core unit test failure as follows: