turnitin / moodle-plagiarism_turnitin

Turnitin Plagiarism plugin for Moodle
http://www.turnitin.com
45 stars 69 forks source link

Issue #448 Move depracted mod methods into hooks. #553

Closed andrewmadden closed 1 month ago

andrewmadden commented 3 years ago

get_form_elements_module > plagiarism_turnitin_coursemodule_standard_elements save_form_elements > plagiarism_turnitin_coursemodule_edit_post_actions

aspark21 commented 2 years ago

Could really do with getting this integrated too @dominicgunn or @stvleung

aspark21 commented 2 years ago

@dwinn good effort catching up with pull requests on Thursday. This is another one of the long standing one's - we have had this in prod for nearly 2 years, works a treat. About time it got integrated though

aspark21 commented 1 year ago

come on @ixiongtii should be an easy one to merge!

aspark21 commented 1 year ago

I've even rebased it here - https://github.com/ucl-isd/moodle-plagiarism_turnitin/tree/UCL_2023033001 - makes it easy to test.

There are no merge conflicts though so this Pull Request is still valid.

We have been running this in prod for 3+ years desperately waiting for Turnitin to actually merge this

aspark21 commented 8 months ago

@ixiongtii not sure why this didn't make it into the 2023082201 release

aspark21 commented 7 months ago

It looks like this was addressed through https://github.com/turnitin/moodle-plagiarism_turnitin/pull/689/files in the latest v2023121901 release. Not sure if it covers everything @andrewmadden's MR did though.