fix errors when displaying student rubric modal in any circumstance

turnitin / moodle-plagiarism_turnitin

Turnitin Plagiarism plugin for Moodle

http://www.turnitin.com

45 stars 69 forks source link

fix errors when displaying student rubric modal in any circumstance #554

Closed jonof closed 3 years ago

jonof commented 3 years ago

Avoid relying on spying into hidden form fields to find course and/or course module ids, and instead declare data attributes on the element where the event handler is attached.

Refs #537.

jonof commented 3 years ago

These were the scenarios I checked:

Teacher: rubric manager from the Assignment settings screen, both for unsaved new and existing instances.
Student: view rubric before submission.
Student: view rubric after submission, both for editable and non-editable submissions.