turnitin / moodle-plagiarism_turnitin

Turnitin Plagiarism plugin for Moodle
http://www.turnitin.com
45 stars 65 forks source link

Fix Minified Javascript code #642

Open TheBryanOpen228 opened 1 year ago

TheBryanOpen228 commented 1 year ago

When updating the plugin to the new 2022092101 Version for moodle 4.0, a Moodle core PhpUnit test was failing, see the issue log here:

core_requirejs_testcase::test_requirejs
Failed asserting that '/vagrant/www/moodle/plagiarism/turnitin/amd/src/modal_eula_launch.min.js' does not contain ".min".
 /vagrant/www/moodle/lib/tests/requirejs_test.php:76
 /vagrant/www/moodle/lib/phpunit/classes/advanced_testcase.php:91

This is because in a commit, (Turnitin commit) the minification of the javascript files was performed erroneously, creating minified files in the src source folder, and minified from the minified in the build folder inside the plagiarism_turnitin plugin, this inconvenience produced a failure in that PhpUnit test of moodle core, since there are not supposed to be any minified files inside the src folder.