turnitin / moodle-plagiarism_turnitin

Turnitin Plagiarism plugin for Moodle
http://www.turnitin.com
45 stars 65 forks source link

Turnitin SDK Deprecated: Return type of Integrations\PhpSdk\Soap::__doRequest #663

Open tlock opened 1 year ago

tlock commented 1 year ago

Hi,

Do we just change the return value to match $one_way = false or is there a reason why it is different as noted by PHP 8.1?

Deprecated: Return type of Integrations\PhpSdk\Soap::doRequest($request, $location, $action, $version, $one_way = null) should either be compatible with SoapClient::__doRequest(string $request, string $location, string $action, int $version, bool $oneWay = false): ?string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ./plagiarism/turnitin/vendor/Integrations/phpsdk-package/src/Soap.php on line 369. Stack trace: line 369 of ./plagiarism/turnitin/vendor/Integrations/phpsdk-package/src/Soap.php: PHP Deprecated thrown line 444 of ./plagiarism/turnitin/vendor/composer/ClassLoader.php: call to include() line 322 of ./plagiarism/turnitin/vendor/composer/ClassLoader.php: call to Composer\Autoload\includeFile() line 12 of ./plagiarism/turnitin/vendor/Integrations/phpsdk-package/src/MembershipSoap.php: call to Composer\Autoload\ClassLoader->loadClass() line 444 of ./plagiarism/turnitin/vendor/composer/ClassLoader.php: call to include() line 322 of ./plagiarism/turnitin/vendor/composer/ClassLoader.php: call to Composer\Autoload\includeFile() line 879 of ./plagiarism/turnitin/vendor/Integrations/phpsdk-package/src/TurnitinAPI.php: call to Composer\Autoload\ClassLoader->loadClass() line 406 of ./plagiarism/turnitin/classes/turnitin_user.class.php: call to Integrations\PhpSdk\TurnitinAPI->createMembership() line 104 of ./plagiarism/turnitin/classes/turnitin_view.class.php: call to turnitin_user->join_user_to_class() line 380 of ./plagiarism/turnitin/lib.php: call to turnitin_view->add_elements_to_settings_form() line 3037 of ./plagiarism/turnitin/lib.php: call to plagiarism_plugin_turnitin->get_form_elements_module() line 992 of ./course/moodleform_mod.php: call to plagiarism_turnitin_coursemodule_standard_elements() line 878 of ./course/moodleform_mod.php: call to moodleform_mod->plugin_extend_coursemodule_standard_elements() line 363 of ./mod/quiz/mod_form.php: call to moodleform_mod->standard_coursemodule_elements() line 214 of ./lib/formslib.php: call to mod_quiz_mod_form->definition() line 131 of ./course/moodleform_mod.php: call to moodleform->construct() line 58 of ./mod/quiz/mod_form.php: call to moodleform_mod->__construct() line 152 of ./course/modedit.php: call to mod_quiz_mod_form->__construct()

Regards, Tim