search

turnitin / moodle-plagiarism_turnitin

Turnitin Plagiarism plugin for Moodle
http://www.turnitin.com
45 stars 65 forks source link

Fix: Use proper Modal Dialogue for eula modal #682

Closed ixiongtii closed 6 months ago

andrii-ilin commented 6 months ago

@ixiongtii I think we need to add a build folder to gitignore file, builds should not be a part of the repo...

ixiongtii commented 6 months ago

@ixiongtii I think we need to add a build folder to gitignore file, builds should not be a part of the repo...

Ok, I've added amd/build to the gitignore. Can I get another review? @andrii-ilin

danmarsden commented 6 months ago

Please don't do that! Moodle plugins do include the build folder. (I know this differs from some other projects) in moodles case the built amd files should be included and removing them from git will cause all sorts of problems for end-users as they will not expect it.

andrii-ilin commented 6 months ago

@danmarsden unexpected :-) , thanks for letting us know, @ixiongtii sorry, my bad, I didn't expect that build folders and files should be commited

danmarsden commented 6 months ago

thanks @andrii-ilin - glad I jumped in before you merged that in - although I'm surprised to see work in this space going on while other important issues like #553 are being neglected which is needed asap so that sites using Moodle 4.3 can use Turnitin (at the moment sites that have upgraded to Moodle 4.3 cannot use Turnitin code without adding that patch manually themselves.)