search

turnitin / moodle-plagiarism_turnitin

Turnitin Plagiarism plugin for Moodle
http://www.turnitin.com
45 stars 65 forks source link

Moodle 4.3 deprecation and mutated session #697

Open ScottVerbeek opened 5 months ago

ScottVerbeek commented 5 months ago

Steps to reproduce on a vanilla Moodle 4.3.2 instance running on PHP 8.1.24 and given your plagiarism is setup:

image

For convenience I have copied the messages:

Deprecation:

Deprecated: Return type of Integrations\PhpSdk\Soap::__doRequest($request, $location, $action, $version, $one_way = null) should either be compatible with SoapClient::__doRequest(string $request, string $location, string $action, int $version, bool $oneWay = false): ?string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vanilla-403/plagiarism/turnitin/vendor/Integrations/phpsdk-package/src/Soap.php on line 369

Muted session:

Script /course/modedit.php mutated the session after it was closed: $SESSION->editedpages

    line 791 of /lib/classes/session/manager.php: call to debugging()
    line ? of unknownfile: call to core\session\manager::check_mutated_closed_session()
    line 159 of /lib/classes/shutdown_manager.php: call to call_user_func_array()
    line ? of unknownfile: call to core_shutdown_manager::shutdown_handler()
simmonsgc commented 3 days ago

In testing turnitintooltwo plugin version 2024032901 on Moodle version 4.3.5+ (Build: 20240614) today, I received similar warning:

( ! ) Deprecated: Return type of Integrations\PhpSdk\Soap::__doRequest($request, $location, $action, $version, $one_way = null) should either be compatible with SoapClient::__doRequest(string $request, string $location, string $action, int $version, bool $oneWay = false): ?string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/asulearn-test.appstate.edu/plagiarism/turnitin/vendor/Integrations/phpsdk-package/src/Soap.php on line 369

In my case, steps to reproduce:

Thanks,