Fix incorrect grader for mod_assign

[sumaiyamannan]

Hi,

This fixes the issue of incorrect grader as explained in https://github.com/turnitin/moodle-plagiarism_turnitin/issues/644

Summary:

The grader of the assignment is at times showing as the student or the system admin, when the assignment was actually graded by a teacher

Steps to reproduce:

• Create a new assignment by teacher role mod/assign/view.php?id=xyz -- Display Similarity Reports to Students: Yes
• Login as the student and go to the assignment view page and submit assignment
• Wait for Turntin report to show percentage for plagiarism (by running cron twice ? and waiting)
• Login as teacher, go to assignment view page click on the percentage and go to Turntin
• Click on comments and grade section to enter grade and comments
• Close window
• Go go assignment view page, wait for the page to refresh automatically and release grade
• Login as student and go to assignment view page
• Click on the percentage icon and for the window to open in Turntin. View the grade and marker feedback by clicking the comment icon (the 3rd icon in the rightside) and close the window
• Wait for the assignment view page to refresh on its own
• Confirm that the feedback section is showing the grader as the student
• OR
• You will see the grader as the system admin

Regards, Sumaiya

[danmarsden]

@ixiongtii can you please make sure this sits high on your list? - it's pretty vital for a number of our clients that the grader presents correct information - it's confusing to users when the grader is set incorrectly and gives potential for issues with security and privacy teams - particularly when the logs state a user has managed to grade themselves when that is incorrect.

[ixiongtii]

Hi, I've passed this issue along and we'll get this addressed. Thanks all for the catch.