turnitin / moodle-plagiarism_turnitin

Turnitin Plagiarism plugin for Moodle
http://www.turnitin.com
GNU General Public License v3.0
49 stars 71 forks source link

We’ve noticed high latency... or Undefined property $version during install #770

Closed leonstr closed 1 week ago

leonstr commented 1 week ago

If you install plagiarism_turnitin 2024072401 on an existing Moodle 4.5 site the message We’ve noticed high latency in your connection to Turnitin. To help you remedy this, we’ve turned off automatic updates to the inbox. Refresh to update submissions appears at the top of the Current release information page (admin/index.php) during plugin install.

If you install Moodle 4.5 with the plagiarism_turnitin 2024072401 already present in the source code directory you get Warning: Undefined property: stdClass::$version in /var/www/moodle/plagiarism/turnitin/db/hooks.php on line 25 at the top of the Installation page (admin/index.php).

This appears to be because the before_standard_top_of_body_html_generation hook is used but is missing a check for the installation or upgrade states:

Callbacks are executed during system installation and all upgrades, the callback methods must verify the plugin is in correct state. Often the easiest way is to use function during_initial_install() or version string from the plugin configuration.

leonstr commented 1 week ago

Fix merged.