search

turnitin / moodle-plagiarism_turnitinsim

7 stars 9 forks source link

A disabled module could cause an invalid course module error #178

Open voegii opened 2 weeks ago

voegii commented 2 weeks ago

The callback function *_coursemodule_edit_post_actions in lib.php should always return the data.

https://github.com/turnitin/moodle-plagiarism_turnitinsim/blob/9a37633b0ce92866576f3f3d45641b1d8a9f386d/lib.php#L944 could cause undesirable results e.g. an invalid course module error or conflicts with other plugins.

Change it to return $data;

alcarola commented 4 days ago

Hi, and thanks for posting this!

I made the change, but it still does not work for me. I got the following error message:

Call to undefined method plagiarism_plugin_turnitinsim::plagiarism_turnitinsim_coursemodule_standard_elements()

... and this stack trace: line 46 of /plagiarism/turnitinsim/classes/defaults_form.class.php: Error thrown line 214 of /lib/formslib.php: call to plagiarism_turnitinsim_defaults_form->definition() line 40 of /plagiarism/turnitinsim/defaults.php: call to moodleform->__construct()

Grateful for any help!

alcarola commented 1 day ago

I should maybe add that I'm running Moodle 4.1.14+ Build 20241011, updated via git, on a CentOS server.

I am on the develop branch of turnitinsim, updated using a git pull (before making the update mentioned by voegii above) on 14 October 2024.