search

turnkeylinux / tracker

TurnKey Linux Tracker
https://www.turnkeylinux.org
71 stars 16 forks source link

Turnkey Linux Core confconsole fails to add sasl password with spaces in it #1994

Closed valankar closed 1 day ago

valankar commented 2 weeks ago

Gmail app passwords are auto-generated and have spaces in them. Suppose my password is "XXXX YYYY".

When I run confconsole and setup an SMTP relay, I can enter the gmail information and the test actually works fine. However, sending email fails on Postfix.

Looking at /etc/postfix/sasl_passwd, it contained:

[smtp.gmail.com]:25 my@email.com:XXXX

It is missing the rest of the password. When I manually edit the file to fix the password and run postmap, it works.

I am using turnkey-wireguard-18.1-bookworm-amd64.

OnGle commented 2 weeks ago

Thanks for the report, as far as I can tell the issue lies here (unquoted $@)

https://github.com/turnkeylinux/confconsole/blob/51da6b3b2c7fd6d3e76256dce0e215e7597c61c5/plugins.d/Mail_Relaying/mail_relay.sh#L75

When I find a moment I'll post a PR that addresses this

JedMeister commented 1 day ago

closed by https://github.com/turnkeylinux/confconsole/pull/87

I'll rebuild and push to the TKL apt repo ASAP.