search

turquoiseowl / i18n

Smart internationalization for ASP.NET
Other
556 stars 156 forks source link

add some improvements #178

Closed lazareveugene closed 9 years ago

lazareveugene commented 9 years ago

i can't create proper pull request without broken formatting

so i create issue to add some lines to files

src/i18n/ResponseFilter.cs

change line 93: if (page != null && page.IsPostBack && !String.IsNullOrEmpty(entity) && !String.IsNullOrEmpty(entity.Replace("\r","").Split('\n')[0])) {

this is needed for proper handle requests

src/i18n.Domain/Concrete/POTranslationRepository.cs

add lines from 134: var templateFilePath = GetAbsoluteLocaleDir() + "/messages.pot"; var POTDate = DateTime.Now; if (File.Exists(templateFilePath)) { POTDate = File.GetLastWriteTime(templateFilePath); }

add lines from 184: stream.WriteLine("\"Project-Id-Version: \n\""); stream.WriteLine("\"POT-Creation-Date: " + POTDate.ToString("yyyy-MM-dd HH:mmzzz") + "\n\""); stream.WriteLine("\"PO-Revision-Date: " + DateTime.Now.ToString("yyyy-MM-dd HH:mmzzz") + "\n\""); stream.WriteLine("\"MIME-Version: 1.0\n\""); stream.WriteLine("\"Content-Type: text/plain; charset=utf-8\n\""); stream.WriteLine("\"Content-Transfer-Encoding: 8bit\n\""); stream.WriteLine("\"X-Generator: i18n.POTGenerator\n\""); stream.WriteLine();

add lines from 295: stream.WriteLine("\"Project-Id-Version: \n\""); stream.WriteLine("\"POT-Creation-Date: " + DateTime.Now.ToString("yyyy-MM-dd HH:mmzzz") + "\n\""); stream.WriteLine("\"MIME-Version: 1.0\n\""); stream.WriteLine("\"Content-Type: text/plain; charset=utf-8\n\""); stream.WriteLine("\"Content-Transfer-Encoding: 8bit\n\""); stream.WriteLine("\"X-Generator: i18n.POTGenerator\n\""); stream.WriteLine();

this is need for support editing in i18n apps

turquoiseowl commented 9 years ago

Done as request. Let me know if I got anything wrong.

I had the same problem as you with those files! Thanks for persevering.

lazareveugene commented 9 years ago

Cool, i 'll check

Also I want to add plural support on next week 22.01.2015 19:40 пользователь "Martin Connell" notifications@github.com написал:

Done as request. Let me know if I got anything wrong.

I had the same problem as you with those files! Thanks for persevering.

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71029487.

lazareveugene commented 9 years ago

when you paste the code you got dublicate lines remove this lines POTranslationRepository.cs 293 POTranslationRepository.cs 182

other is ok

turquoiseowl commented 9 years ago

There is now a mixture of \\n and \n in those string literals.

Please confirm which is correct.

turquoiseowl commented 9 years ago

I'm guessing it should be \\n otherwise you're outputting a newline followed by the closing double quote on that newline.

lazareveugene commented 9 years ago

Hello,

yeah, it should be \n

we need to pass escaped newline

Лазарев Евгений mailto: lazareveugene@gmail.com GoogleTalk: lazareveugene@gmail.com lazareveugene@gmail.comSKYPE: lazareveugene SIP: 84773@sip.zadarma.com Cellular: +79058077697

2015-01-23 17:24 GMT+05:00 Martin Connell notifications@github.com:

I'm guessing it should be \n otherwise you're outputting a newline followed by the closing double quote on that newline.

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71186469.

turquoiseowl commented 9 years ago

Okay, done that. Please confirm it outputs as expected.

From: Lazarev Eugene [mailto:notifications@github.com] Sent: 23 January 2015 12:26 To: turquoiseowl/i18n Cc: Martin Connell Subject: Re: [i18n] add some improvements (#178)

Hello,

yeah, it should be \n file:///\n

we need to pass escaped newline

Лазарев Евгений mailto: lazareveugene@gmail.com GoogleTalk: lazareveugene@gmail.com lazareveugene@gmail.comSKYPE: lazareveugene SIP: 84773@sip.zadarma.com Cellular: +79058077697

2015-01-23 17:24 GMT+05:00 Martin Connell notifications@github.com:

I'm guessing it should be \n file:///\n otherwise you're outputting a newline followed by the closing double quote on that newline.

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71186469.

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71186602 . https://github.com/notifications/beacon/ADFw_SrKqcqjt4bWv3mHO6ZqKTG4imfqks5nkjVTgaJpZM4DVW_5.gif

lazareveugene commented 9 years ago

hello,

also please remove this lines of code POTranslationRepository.cs 293 and 182

as you can see this lines already outputed to the stream

Лазарев Евгений mailto: lazareveugene@gmail.com GoogleTalk: lazareveugene@gmail.com lazareveugene@gmail.comSKYPE: lazareveugene SIP: 84773@sip.zadarma.com Cellular: +79058077697

2015-01-23 18:25 GMT+05:00 Martin Connell notifications@github.com:

Okay, done that. Please confirm it outputs as expected.

From: Lazarev Eugene [mailto:notifications@github.com] Sent: 23 January 2015 12:26 To: turquoiseowl/i18n Cc: Martin Connell Subject: Re: [i18n] add some improvements (#178)

Hello,

yeah, it should be \n file:///\n

we need to pass escaped newline

Лазарев Евгений mailto: lazareveugene@gmail.com GoogleTalk: lazareveugene@gmail.com lazareveugene@gmail.comSKYPE: lazareveugene SIP: 84773@sip.zadarma.com Cellular: +79058077697

2015-01-23 17:24 GMT+05:00 Martin Connell notifications@github.com:

I'm guessing it should be \n file:///\n otherwise you're outputting a newline followed by the closing double quote on that newline.

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71186469.

— Reply to this email directly or view it on GitHub < https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71186602> . < https://github.com/notifications/beacon/ADFw_SrKqcqjt4bWv3mHO6ZqKTG4imfqks5nkjVTgaJpZM4DVW_5.gif>

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71192441.

turquoiseowl commented 9 years ago

Done.

From: Lazarev Eugene [mailto:notifications@github.com] Sent: 23 January 2015 13:29 To: turquoiseowl/i18n Cc: Martin Connell Subject: Re: [i18n] add some improvements (#178)

hello,

also please remove this lines of code POTranslationRepository.cs 293 and 182

as you can see this lines already outputed to the stream

Лазарев Евгений mailto: lazareveugene@gmail.com GoogleTalk: lazareveugene@gmail.com lazareveugene@gmail.comSKYPE: lazareveugene SIP: 84773@sip.zadarma.com Cellular: +79058077697

2015-01-23 18:25 GMT+05:00 Martin Connell notifications@github.com:

Okay, done that. Please confirm it outputs as expected.

From: Lazarev Eugene [mailto:notifications@github.com] Sent: 23 January 2015 12:26 To: turquoiseowl/i18n Cc: Martin Connell Subject: Re: [i18n] add some improvements (#178)

Hello,

yeah, it should be \n file:///\n file:///\n

we need to pass escaped newline

Лазарев Евгений mailto: lazareveugene@gmail.com GoogleTalk: lazareveugene@gmail.com lazareveugene@gmail.comSKYPE: lazareveugene SIP: 84773@sip.zadarma.com Cellular: +79058077697

2015-01-23 17:24 GMT+05:00 Martin Connell notifications@github.com:

I'm guessing it should be \n file:///\n file:///\n otherwise you're outputting a newline followed by the closing double quote on that newline.

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71186469.

— Reply to this email directly or view it on GitHub < https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71186602> . < https://github.com/notifications/beacon/ADFw_SrKqcqjt4bWv3mHO6ZqKTG4imfqks5nkjVTgaJpZM4DVW_5.gif>

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71192441.

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71192854 . https://github.com/notifications/beacon/ADFw_Wn5u6DdmVYm87rbne7l63lfT1XKks5nkkQngaJpZM4DVW_5.gif

lazareveugene commented 9 years ago

cool, now that's all

Здравствуйте,

Лазарев Евгений mailto: lazareveugene@gmail.com GoogleTalk: lazareveugene@gmail.com lazareveugene@gmail.comSKYPE: lazareveugene SIP: 84773@sip.zadarma.com Cellular: +79058077697

2015-01-23 18:34 GMT+05:00 Martin Connell notifications@github.com:

Done.

From: Lazarev Eugene [mailto:notifications@github.com] Sent: 23 January 2015 13:29 To: turquoiseowl/i18n Cc: Martin Connell Subject: Re: [i18n] add some improvements (#178)

hello,

also please remove this lines of code POTranslationRepository.cs 293 and 182

as you can see this lines already outputed to the stream

Лазарев Евгений mailto: lazareveugene@gmail.com GoogleTalk: lazareveugene@gmail.com lazareveugene@gmail.comSKYPE: lazareveugene SIP: 84773@sip.zadarma.com Cellular: +79058077697

2015-01-23 18:25 GMT+05:00 Martin Connell notifications@github.com:

Okay, done that. Please confirm it outputs as expected.

From: Lazarev Eugene [mailto:notifications@github.com] Sent: 23 January 2015 12:26 To: turquoiseowl/i18n Cc: Martin Connell Subject: Re: [i18n] add some improvements (#178)

Hello,

yeah, it should be \n file:///\n file:///\n

we need to pass escaped newline

Лазарев Евгений mailto: lazareveugene@gmail.com GoogleTalk: lazareveugene@gmail.com lazareveugene@gmail.comSKYPE: lazareveugene SIP: 84773@sip.zadarma.com Cellular: +79058077697

2015-01-23 17:24 GMT+05:00 Martin Connell notifications@github.com:

I'm guessing it should be \n file:///\n file:///\n otherwise you're outputting a newline followed by the closing double quote on that newline.

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71186469.

— Reply to this email directly or view it on GitHub < https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71186602> . <

https://github.com/notifications/beacon/ADFw_SrKqcqjt4bWv3mHO6ZqKTG4imfqks5nkjVTgaJpZM4DVW_5.gif>

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71192441.

— Reply to this email directly or view it on GitHub < https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71192854> . < https://github.com/notifications/beacon/ADFw_Wn5u6DdmVYm87rbne7l63lfT1XKks5nkkQngaJpZM4DVW_5.gif>

— Reply to this email directly or view it on GitHub https://github.com/turquoiseowl/i18n/issues/178#issuecomment-71193471.