search

turquoiseowl / i18n

Smart internationalization for ASP.NET
Other
556 stars 156 forks source link

Fix redirects ignoring langtag #238

Closed ajbeaven closed 8 years ago

ajbeaven commented 8 years ago

Fixes #222

As @Zeroto mentions in the issue above, LocalizeUrl is only used when processing outgoing URLs so the incomingUrl parameter may not be necessary. Let me know if you want to get rid of it and I'll make the change.

ajbeaven commented 8 years ago

Here's the commit that added this: https://github.com/turquoiseowl/i18n/commit/555d36c6a6c8f10318a2aa0277279d35e82a80cc. Not sure what the described problem related to but it may need to be considered before merging.

turquoiseowl commented 8 years ago

Hmm, https://github.com/turquoiseowl/i18n/commit/555d36c6a6c8f10318a2aa0277279d35e82a80cc may be an erroneous fix. There was a serious problem with Scheme2 which has now been sorted which may have been what was behind that commit.

I suggest we leave the incomingUrl param in there for now in case we need to reverse this mod.

ajbeaven commented 8 years ago

Perhaps that's true, though note it was added more than 2 years ago. This is a great thing to fix - presumably it affects Scheme1 too, it's just that you don't notice due to a redirect. Thanks @turquoiseowl, great work on this repo - looking forward to the nuget package update :)