search

turquoiseowl / i18n

Smart internationalization for ASP.NET
Other
556 stars 156 forks source link

wildcards for blacklists and disabling generated references #309

Closed Sshnyari closed 7 years ago

Sshnyari commented 7 years ago

see #303 and #304

turquoiseowl commented 7 years ago

I take it this PR has two features? Are you able to submit individually?

Are you be able to include a README section on this? It will help others to use this feature and also me to work out what I'm looking at.

There is a method called TransformToken with nothing else to help me and others work out what it does.

(By Search Character do you mean Wildcard Character?)

Tests are appreciated, thanks; but more comments in them would be appreciated.

Sshnyari commented 7 years ago

I can split it into two different PR, but one is dependant on the other They both use the same newelly created files (unit test files)

Sshnyari commented 7 years ago

How do you suggest we do this ? Which feature should come first ?

turquoiseowl commented 7 years ago

The DisableReferences code looks good as is if you are able to resubmit that along with the README section.

WRT the wildcard code, please see notes above, thanks.