search

turquoiseowl / i18n

Smart internationalization for ASP.NET
Other
556 stars 156 forks source link

messages.po picking up external .po files #313

Closed tOmoness closed 7 years ago

tOmoness commented 7 years ago

With the addition of using external .po files in the latest build I thought I'd give it go. I set up one called external.po in my locale folder and added some entries, but upon building and running the post build generator it picks up the entries from my external .po file and places them in the messages.po file as commented out entries.

Is this the desired effect?

Sshnyari commented 7 years ago

I don't think so I'll look into it

tOmoness commented 7 years ago

@Sshnyari bit more info... So I need to translate dynamic data (not known until run time), so I made a po file that would contain the dynamic data. Then when the PostBuild generator runs it takes the translations from the dynamic data po file and adds them to messages.po commented out because they don't exist in code. (Hope that helps a bit)

Sshnyari commented 7 years ago

Thanks for the info I added a fix to ignore other po files during postbuild see #315

tOmoness commented 7 years ago

@Sshnyari thanks for taking a look at that!

turquoiseowl commented 7 years ago

Can we close this issue?

tOmoness commented 7 years ago

Yes we can. :)