search

turquoiseowl / i18n

Smart internationalization for ASP.NET
Other
556 stars 156 forks source link

'DisableReferences' switch should work like the GetText '--no-location' switch #341

Open Razsiel opened 7 years ago

Razsiel commented 7 years ago

Hey turquoiseowl,

We're using your tool for our website, but have come across some issues regarding the generated .po files using git; the generated file location-references (#: folder/file.extension). Since we are continuously adding new code, the po files are constantly viewed as changed by our git tracker, which has caused some nasty conflicts already.

A solution to our problem would be to be able to not have these lines generated. I tried updating to 2.1.10, hoping the DisabledReferences option fixed it, but it seems I was mistaken. I've searched online and found that GNU's gettext supports disabling these location reference (https://www.gnu.org/software/gettext/manual/html_node/msgmerge-Invocation.html (search for '--no-location')) and was wondering if this could be included in i18n via an option 'DisableLocationComments' (or something similair).

I tried implementing it myself, but unfortuantely to no avail.

turquoiseowl commented 7 years ago

It sounds like you want what the i18n.DisableReferences setting should do. What happens when you set that to true? (NB: it is DisableReferences rather than DisabledReferences as you wrote.)

Razsiel commented 7 years ago

I did have DisableReferences correctly in my web.config file (it was a typo in the issue description) and have it set as true. If I then build the project and the i18n.PostBuild.exe runs it regenerates any manually removed location comments.

turquoiseowl commented 7 years ago

It looks to be as possible bug then with the DisableReferences feature.

I'm up to my neck in other work at the moment so cannot say when I'll be able to look into it. Any chance you wouild be able to debug it yourself?

Thanks.

Razsiel commented 7 years ago

I'll have to talk with my employer first to get the required time and freedom to do it since it's a non-prio item on our list at the moment, just a QoL improvement. Will keep you up to date!