turquoiseowl / i18n

Smart internationalization for ASP.NET

Other

556 stars 156 forks source link

Translate wont works when file havent comment lines#:? #351

Closed gilbertogwa closed 3 years ago

gilbertogwa commented 6 years ago

Why the translate works only when POs files have comments lines (with #: characters )? Can you update documments with this information? Apps that generates POs files don't include comments by default...

Won't works:

msgid "I am a text" msgstr ""

Works:

:

msgid "I am a text" msgstr ""

calway commented 6 years ago

Seems I ran into this when testing a console app as well. After adding these and changing nothing else in the sample from @ajbeaven it suddenly worked

turquoiseowl commented 5 years ago

Closing. Please re-open is appropriate. Thanks.

adrinr commented 5 years ago

I ran into this problem, po files don't work if the optional comments don't exist. Would be possible to re-open the issue and to have a look?

turquoiseowl commented 5 years ago

Happy to re-open. As to investigating, I can't commit to anything just now.

Please feel free to submit a PR with fix. Thanks.

vhatuncev commented 3 years ago

@turquoiseowl this can be closed.