search

turquoiseowl / i18n

Smart internationalization for ASP.NET
Other
556 stars 156 forks source link

URL with named anchor not localising #372

Closed Thrudd closed 5 years ago

Thrudd commented 5 years ago

I've hit a snag thats got me stumped and I'm not sure if its a bug or just some limitation that I'm unaware of.

My issue is that I've made a html helper using MergeAttribute to generate a menu eg: link.MergeAttribute("href", menuItem.URL); It works as expected unless the URL includes a named anchor.

So '/testpage' correctly becomes '/en/testpage' but '/testpage#foo' just gets rendered as '/testpage#foo'

Could it be that the URL with the anchor is failing the regex in EarlyUrlLocalizer.cs? I'm hopeless at regex so I really can't tell (It's a dark art I've never managed to get my head around) or could something else be tripping it up?

turquoiseowl commented 5 years ago

Yes, it was a bug. Hopefully fixed now. Let me know if not.

New release 2.1.13 just published with the fix.

Thrudd commented 5 years ago

Ah great stuff. Yeah that sorted it out. Glad I found a bug, I really thought I'd missed something. Thanks for all your hard work on i18n it's fantastic.

turquoiseowl commented 5 years ago

Good to know, thanks.