search

turquoiseowl / i18n

Smart internationalization for ASP.NET
Other
556 stars 156 forks source link

Rewrite http response headers only in ResponseFilter Flush method. #400

Closed vhatuncev closed 3 years ago

vhatuncev commented 4 years ago

Made changes as suggested in #338 Extract http headers rewrite as separate method ProcessOutgoingHeaders. Call ProcessOutgoingHeaders only when flushing http response. ProcessOutgoingHeaders - make positive logic cases only. StringExtensions.cs - removed unused references.

vhatuncev commented 4 years ago

Hello Martin @turquoiseowl, first of all I want to say thank you for i18n project. I use it on the project and it's really does the job for translation and I want to pay back for your work and support this project. I have few other features to add which is also might be interesting to the community but as I see you don't have time to review my PRs. So I just want to ask if it makes sense to continue?

turquoiseowl commented 3 years ago

Thanks again for this. Nice solution!

If I've not missed the boat, I would certainly be happy to discuss any ideas you have for new features.

vhatuncev commented 3 years ago

@turquoiseowl I think I will have time in near future to commit for this project. Can we exchange emails or any other faster communication channel to discuss next steps? My email vasiliy.hatunsev@gmail.com