search

tursodatabase / kysely-libsql

Kysely dialect for sqld
MIT License
51 stars 8 forks source link

use @libsql/client instead of @libsql/hrana-client #5

Closed ottomated closed 4 months ago

ottomated commented 7 months ago

This repo still uses the internal @libsql/hrana-client library. This PR updates it to use @libsql/client for parity.

jkonowitch commented 6 months ago

This is a very impactful change as we are using Kysely for our ORM, and having access to the full set of @libsql/client features (e.g. embedded replicas) would be a big win. cc @penberg

ottomated commented 6 months ago

@jkonowitch I've got a fork up at @ottomated/kysely-libsql if you want to use that in the meantime. You'll also need to apply this patch: https://github.com/libsql/hrana-client-ts/pull/14

penberg commented 4 months ago

Depends on https://github.com/tursodatabase/libsql-client-ts/pull/219 being merged

ottomated commented 4 months ago

Can this be merged now, @penberg ?

ottomated commented 4 months ago

I see that the feature hasn't been released yet. Hopefully this can all go through soon!

penberg commented 4 months ago

Yes, thanks for the ping @ottomated! Let me try to publish a new version to npm registry now.

ottomated commented 4 months ago

@penberg I have another commit to this repo ready to go for when the next version of @libsql/client is published (the PR was merged but not released) https://github.com/tursodatabase/libsql-client-ts/blob/main/CHANGELOG.md