Closed avinassh closed 1 year ago
It's better if we merge #24 first, then we can run the tests in this PR to make sure everything is alright
Thanks @avinassh. Looks mostly good but I think the PR needs some cleanup. Please remove commits that introduce changes that are removed later. Also please remove your credentials :)
@haaawk hey, I have cleaned up and squashed all the commits
Thanks @avinassh. Looks much better. Just one last question.
I have added
PrepareContext
andBeginTx
methods. I have also replacedcontext.TODO
withcontext.Background
Following methods are required because of interface, but they are not used:
Begin
Prepare
stmt
structExec
andQuery
I have confirmed this by keeping
panic()
calls and running the test suite.Also, I updated the example snippet to use
ctx
in every call and included a sample of prepared statements