search

tursodatabase / libsql-client-go

Go client API for libSQL
MIT License
159 stars 23 forks source link

Support inserting bool #78

Closed p0isonra1n closed 6 months ago

p0isonra1n commented 9 months ago

This fixes inserting bools for me.

I noticed you made an issue for this @haaawk #3

Please let me know if you need me to do anything else to get this merged.

GeorgeMac commented 9 months ago

Would love to see this get some attention 🙌 +1

penberg commented 6 months ago

@avinassh @haaawk looks good to me, any objections to merging?

avinassh commented 6 months ago

@p0isonra1n I closed the PR by mistake. I tried to rebase the branch with main and it went wrong. Fixing it now

avinassh commented 6 months ago

I rebased your pr branch with main and the diff was zero. Turns out the same changes were already merged from a different PR - https://github.com/tursodatabase/libsql-client-go/commit/a6918fbc32d1d92b5837a5b04af959a028cd2aaf - https://github.com/tursodatabase/libsql-client-go/pull/83