tursodatabase / libsql-client-rs

libSQL Rust client library can be used to communicate with sqld natively over HTTP protocol with native Rust interface.
MIT License
75 stars 29 forks source link

Incorrect implementation of hrana batches #12

Open MarinPostma opened 1 year ago

MarinPostma commented 1 year ago

After giving it a quick glance, I think the implementation of batch for hrana is incorrect. If we want the semantics of a batch to match that of http batches, and fail (and potentially rollback) if any error occurs.

This is how sqld does it: https://github.com/libsql/sqld/blob/main/sqld/src/database/mod.rs#L66-L104