fix: Do not make rows read-only

tursodatabase / libsql-client-ts

TypeScript/JavaScript client API for libSQL

https://docs.turso.tech/sdk/ts/quickstart

MIT License

289 stars 37 forks source link

fix: Do not make rows read-only #166

Closed netroy closed 9 months ago

netroy commented 9 months ago

Since Object.defineProperty defaults to configurable: false and writable: false, all row objects created in libsql-client currently have read-only columns. Irrespective of our opinions on immutability, this behavior is unfortunately not backward-compatible with any of the other sqlite JS/TS clients.

I started implementing a libSQL driver in TypeORM, but the tests are currently failing because of fields on row objects being read-only.

netroy commented 9 months ago

Thanks @penberg 🙏🏽

penberg commented 9 months ago

Thanks for fixing this @netroy!