Should shell `.dump` use a transaction?

tursodatabase / libsql-shell-go

7 stars 7 forks source link

Should shell `.dump` use a transaction? #117

Closed CodingDoug closed 1 year ago

CodingDoug commented 1 year ago

sqlite3 .dump wraps the entire SQL output (after PRAGMA foreign_keys=OFF;) in BEGIN TRANSACTION; and COMMIT;. Turso's shell does not. Should it? That would defend against a partial set of statements from executing in the face of an error part way through.

CodingDoug commented 1 year ago

Oops, duplicate of #75

luisfvieirasilva commented 1 year ago

@CodingDoug, I'll close this one since #75 has a little bit more context about why we're missing transactions on .dump