search

tursodatabase / libsql-shell-go

7 stars 7 forks source link

Batch queries when using HTTP client #168

Closed athoscouto closed 6 months ago

athoscouto commented 6 months ago

Description

Batch queries when using HTTP client.

For now, we cannot do it for all URL schemes, since the WS client doesn't support batching.

haaawk commented 6 months ago

It turns out this change is a no op. The shell does not split query for http/https -> https://github.com/tursodatabase/libsql-shell-go/blob/main/internal/db/db.go#L185

I will revert.

athoscouto commented 6 months ago

@haaawk I tested it and it reduce latency from 12s to 600ms for 1000 writes.

haaawk commented 6 months ago

It wasn't this change but the fact that you made non-interactive shell use https which uses batches instead of websockets which don't use batching at all.