tursodatabase / libsql

libSQL is a fork of SQLite that is both Open Source, and Open Contributions.
https://turso.tech/libsql
MIT License
9.54k stars 252 forks source link

Add libsql_open_sync_with_config #1566

Closed haaawk closed 2 months ago

haaawk commented 2 months ago

Expose interval sync in C bindings.

Fixes #1561

penberg commented 2 months ago

I am fine with this, but curious to know if we can make the API simpler with a libsql_config struct. Is that something we can easily use from Go, for example?

haaawk commented 2 months ago

I am fine with this, but curious to know if we can make the API simpler with a libsql_config struct. Is that something we can easily use from Go, for example?

I would have to check. That would also require update to op-sqlite too.

haaawk commented 2 months ago

Let me know if this looks better @penberg

haaawk commented 2 months ago

I was able to switch go-libsql to use libsql_config and all the tests passed -> https://github.com/tursodatabase/go-libsql/pull/32