search

tursodatabase / libsql

libSQL is a fork of SQLite that is both Open Source, and Open Contributions.
https://turso.tech/libsql
MIT License
9.24k stars 242 forks source link

Switch to SQLCipher cipher #893

Open penberg opened 7 months ago

penberg commented 7 months ago

We integrated https://github.com/utelle/SQLite3MultipleCiphers into the libSQL source tree, but we should really pick one cipher and stick to that. The best one seems to be SQLCipher.

utelle commented 7 months ago

We integrated https://github.com/utelle/SQLite3MultipleCiphers into the libSQL source tree, but we should really pick one cipher and stick to that. The best one seems to be SQLCipher.

Which cipher is the best is debatable. It depends on the goals you want to fulfill - compatibility with SQLite tools and/or applications, speed ...

Actually, PR #894 does NOT select SQLCipher, but wxSQLite3 AES 256.

Under security aspects you should reconsider your decision: you should choose one of the cipher schemes SQLCipher, ChaCha20, or Ascon128, if you don't want to add the ability to choose the cipher scheme at runtime. Use SQLCipher, if you want compatibility with other tools and applications, ChaCha20 if you want speed, or Ascon128 if you want high speed and the smallest amount of additional code.

penberg commented 5 months ago

Linear bot was overly eager, reopening.