search

tursodatabase / turso-cli

Command line interface to Turso.
https://turso.tech
MIT License
224 stars 37 forks source link

GH accounts that are not whitelisted get empty screen after auth #38

Closed CodingDoug closed 1 year ago

CodingDoug commented 1 year ago

Before my GH account was whitelisted, if I tried to turso auth login, I could auth with GH OK, but I was landed on a screen with empty content. I would expect to see instead a helpful error message saying that I should reach out to ChiselStrike staff using the best channel (Discord?).

Edit: since the CLI is handling error cases, we should probably make sure that the experience is reasonable for those who aren't on the allowlist.

penberg commented 1 year ago

@glommer What do you think? We're not planning to make the CLI public (although it kind of is already) so we could make the assumption that everybody who has access is on the allowlist.

glommer commented 1 year ago

we should use every opportunity we have to direct people to talk to us, so I agree with Doug.

Let's say for example someone tries and passes it along to a friend...

Any error message is better than none

CodingDoug commented 1 year ago

For now, I'm mostly interested in defending against the case where someone is not actually on the whitelist that should be (as it happened to me recently).

glommer commented 1 year ago

I am working on this.

glommer commented 1 year ago

Work is actually all on the API - https://github.com/chiselstrike/iku-turso-api/pull/44

penberg commented 1 year ago

Fixed on the API side.