Pull to-device event list out of returned tuple

turt2live / matrix-bot-sdk

TypeScript/JavaScript SDK for Matrix bots

MIT License

199 stars 69 forks source link

Pull to-device event list out of returned tuple #332

Open AndrewFerr opened 1 year ago

AndrewFerr commented 1 year ago

OlmMachine.receiveSyncChanges returns an array of [device messages, room key changes], so emit "to_device.decrypted" with that instead of the entire array.

Fixes regression introduced by #287.

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

Checklist

[x] Tests written for all new code
[x] Linter has been satisfied
[x] Sign-off given on the changes (see CONTRIBUTING.md)

AndrewFerr commented 1 year ago

I intend to add test coverage for this to prevent further regressions (whether self-inflicted or induced by dependency changes).

AndrewFerr commented 1 year ago

On closer examination, the regression wasn't caused by #287, but by a change in the rust-sdk crypto crate which isn't yet in a release of the Node bindings (change = matrix-org/matrix-rust-sdk@98882b9c23bdf03f875abf79060937047425a4c3, merging PR = matrix-org/matrix-rust-sdk#2142).

With that said, this PR will be needed only after a new release of the rust-sdk Node bindings is cut.

AndrewFerr commented 1 year ago

Note that this applies on top of https://github.com/turt2live/matrix-bot-sdk/pull/330 due to requiring an update of the rust-sdk bindings, which necessitates handling the omission of the Sled crypto store.