search

turtle-bazon / cl-maxminddb

GNU Lesser General Public License v3.0
4 stars 3 forks source link

Interned symbols in ASDF file #1

Closed phoe closed 4 years ago

phoe commented 4 years ago

https://github.com/turtle-bazon/cl-maxminddb/blob/a66e6ab7167d63f30c1db024725f6f932cf43acb/cl-maxminddb.asd#L9-L15

I suggest using #:babel or "babel" instead of babel et al in order to avoid polluting the ASDF namespace with newly interned symbols.

turtle-bazon commented 4 years ago

fixed in https://github.com/turtle-bazon/cl-maxminddb/commit/4971ee86ade9afd8d81cb56d2ba5fe2e2645ff6b

phoe commented 4 years ago

Thanks!