turtlebot / turtlebot_apps

A group of simple demos and exmaples to run on your TurtleBot to help you get started with ROS and TurtleBot.
http://www.ros.org/wiki/turtlebot_apps
196 stars 225 forks source link

[WIP] Integrate frontier_exploration. #146

Closed 130s closed 8 years ago

130s commented 8 years ago

Do not review yet, but opinion needed.

Adding a launch and a param file for frontier_exploration.

Question. Particularly because I'm adding dependency, I thought I would add this as a separate package (e.g. turtlebot_samples). However, I'm not adding a sample, instead I'm adding a feature that user's application can utilize, thus I'm adding as another feature in turtlebot_navigation. Is this okay approach?

trainman419 commented 8 years ago

The turtlebot stack already has a significant number of dependencies that slow down the release process.

Instead of adding yet another dependency and increase the load on the maintainers, it's probably better to release these launch files as a new package.

130s commented 8 years ago

Still not ready for the review, but I just created turtlebot_apps/turtlebot_samples package to put all the proposed files in. As you see it's still in turtlebot_apps metapkg. Is this what you meant? @trainman419 Or do we want to create a whole new repository?

trainman419 commented 8 years ago

Having this in the same repository still makes the release of turtlebot_apps depend on the frontier_exploration package and doesn't address any of the issues raised in my previous comment.

130s commented 8 years ago

Can any admins of turtlebot organization create a repository for turtlebot_samples (or whatever makes the best sense)?

trainman419 commented 8 years ago

You can create the package on your own account, demonstrate its viability and usefulness, and then petition to get it moved into the turtlebot organization. You don't need to bother the package maintainers for your personal project.