search

turtlebot / turtlebot_apps

A group of simple demos and exmaples to run on your TurtleBot to help you get started with ROS and TurtleBot.
http://www.ros.org/wiki/turtlebot_apps
196 stars 225 forks source link

remove superfluous leading '/' in topic names #147

Closed v4hn closed 8 years ago

v4hn commented 8 years ago

These are not needed as all topics in question are in the same namespace as the nodes. However, the '/' breaks namespacing, so it becomes impossible to move the whole launch file into a new namespace.

v4hn commented 8 years ago

@tfoote: you seem to be the only one who maintains this module over the last year. Could you spare a minute?

tfoote commented 8 years ago

That looks reasonable. @rohbotics could you test change while your testing?

rohbotics commented 8 years ago

Tested, and nothing broke. Looks good to merge.