Updated publisher queue_size to avoid warning on indigo

turtlebot / turtlebot_apps

A group of simple demos and exmaples to run on your TurtleBot to help you get started with ROS and TurtleBot.

http://www.ros.org/wiki/turtlebot_apps

196 stars 225 forks source link

Updated publisher queue_size to avoid warning on indigo #96

Closed kentsommer closed 10 years ago

stonier commented 10 years ago

Going to merge this one - if its imperative I can come back and do something extra for it later.

tfoote commented 10 years ago

Too many parameters has never been an issue if you have good default values they make no difference. It's best to expose them to the user, if not doing that it's best to pull them into variables and put them at the top of the file or section with a clear name for the developers to view. It's not that it has to happen, but it's better for maintainability. https://stackoverflow.com/questions/47882/what-is-a-magic-number-and-why-is-it-bad

stonier commented 10 years ago

Yeah, I generally keep that in mind for everything I do Tully (and often have to explain the same philosophy to my cleaning robot colleagues!). Parameterising this particular one is getting borderline tedious though :)