search

turtlebot / turtlebot_create_desktop

Visualisation and simulation tools for the iRobot Create
http://www.ros.org/wiki/turtlebot_create_desktop
6 stars 18 forks source link

Fix to CMake set #21

Closed leokoppel closed 8 years ago

leokoppel commented 8 years ago

Fix a build error introduced in #19

Keep CMAKE_CXX_FLAGS as a string, not a semicolon-separated list.

tfoote commented 8 years ago

Thanks!

leokoppel commented 8 years ago

Note there may be a more reliable way of requiring C++11 (for example CXX_STANDARD - see http://stackoverflow.com/a/20165519/431033). I'm not familiar with this repo or CMake so not sure which is best.

Also turtlebot.rosinstall may need to be updated to use the kinetic branch.

tfoote commented 8 years ago

That's great, but unfortunately I believe it's new in cmake 3