search

turtlebot / turtlebot_simulator

Launchers for Gazebo simulation of the TurtleBot
http://www.ros.org/wiki/turtlebot_simulator
99 stars 136 forks source link

Fix missing amcl and gmapping launch files in turtlebot_navigation while creating/navigating map #61

Closed mzaiady closed 7 years ago

mzaiady commented 7 years ago

Fix error No such file or directory gmapping.launch.xml and amcl.launch.xml under turtlebot_navigation/launch/includes/

while calling roslaunch turtlebot_gazebo amcl_demo.launch and also while calling roslaunch turtlebot_gazebo gmapping_demo.launch

And this because of changing the gmapping.launch.xml and amcl.launch.xml on turtlebot_navigation

Created issue: https://github.com/turtlebot/turtlebot_apps/issues/159

mzaiady commented 7 years ago

By the way , this my first pull request on GitHup, so I hope I did not forget something!

stonier commented 7 years ago

LGTM - @kevincwells did you test these?

mzaiady commented 7 years ago

I tested modification on my existing/install version, and it works fine

Then I did the same changes to the branch version, but I did not install/test the copied changes of-course, I it must be test, but I'm new to ROS and only used catkin_make tool, never used rosinstall.

I will try find some time and install it using rosinstall and see.

rohbotics commented 7 years ago

@stonier This patch works in my testing, for both gmapping and amcl.

I think it is good to merge once the white-space is fixed.