Add support for removeFingerprintOnSuccess config property

tus / tus-java-client

The tus client for Java.

https://tus.io

MIT License

213 stars 88 forks source link

Add support for removeFingerprintOnSuccess config property #27

Closed jjrodrig closed 5 years ago

jjrodrig commented 5 years ago

This PR adds removeFingerprintOnSuccess config property to TusClient that allows to define whether the upload URL should be removed from the URL store after a successful upload.

This behaviour is disabled by default and should be enabled by calling:

TusClient.enableRemoveFingerprintOnSuccess()

Closes #26 issue

Acconut commented 5 years ago

Thank you for this PR and your patience.

I had a thorough look at your patch and there are two topic I would like to talk about:

Could you explain what the mockito dependency is about? I never heard about it so I am wondering if it's necessary.
Could you make the uploadFinished method package private? I don't think there is a need of it being public.

jjrodrig commented 5 years ago

Thanks @Acconut I've included my responses as comments in the code review

Acconut commented 5 years ago

Thank you for the changes. I fixed a few trailing whitespace issues and also converted your Windows CRLF line endings back to Unix's LF.

Merged in https://github.com/tus/tus-java-client/commit/003ff8a906ab19c951cc8a54baee27e162c87f55.