Update release workflow and dependencies

tus / tus-java-client

The tus client for Java.

https://tus.io

MIT License

213 stars 88 forks source link

Update release workflow and dependencies #50

Closed cdr-chakotay closed 2 years ago

cdr-chakotay commented 2 years ago

Pinned Soatype Staging Profile ID
Updated Dependencies, in course of that:
- Removed Test expectation for "Expect: 100-continue" header as Mockserver does not support it at the moment.
- Did NOT deactivate sending this header, as it is needed for the chunked mode.
- Set min Requirement from Java 6 to Java 7 => Gradle minimum requirements

cdr-chakotay commented 2 years ago

Is this ready for review/merge yet?

Did NOT deactivate sending this header, as it is needed for the chunked mode.

You you explain more why we cannot remove it? Did you try removing it and it caused errors? AFAIK, connection.setChunkedStreamingMode should set this header anyways.

Yes, I can. I stepped through the code and it does not seem to be set. As a result also the Test, which sends a server error 500 to the client does not cause an exception => When I set it manually it waits for the server response

Acconut commented 2 years ago

Yes, I can. I stepped through the code and it does not seem to be set. As a result also the Test, which sends a server error 500 to the client does not cause an exception => When I set it manually it waits for the server response

Ok, interesting. Then let's keep it!