Major release: v2 - Githubissues

tus / tus-java-client

The tus client for Java.

https://tus.io

MIT License

213 stars 88 forks source link

Major release: v2 #78

Open Acconut opened 1 year ago

Acconut commented 1 year ago

Major changes:

[ ] Replace loop around uploadChunk() with start and stop methods similar to tus-js-client (remove chunk size as well)
[ ] Replace HttpURLConnection with more modern HTTP client (maybe okhttp or HttpClient?)
- Add support for setting proxies (https://github.com/tus/tus-java-client/issues/52)
[ ] Implement a more capable system for URL storage (https://github.com/tus/tus-java-client/pull/68)

Additional features:

[ ] Easier access to headers (https://github.com/tus/tus-java-client/issues/59)
[ ] Require size parameter for TusUpload (https://github.com/tus/tus-java-client/issues/34)

lealceldeiro commented 1 year ago

Hey, @Acconut , could you share an ETA for this release?

Acconut commented 1 year ago

Sorry, we do not have any schedule available to share. Explicit work on this has not yet started.

LaravZ commented 1 year ago

Hi @Acconut,

Would it be possible to add support for proxies earlier than v2 if I were to contribute code in a PR? I don't wish to override code in multiple places or use system settings to accomplish this.

I believe the change would be rather simple if we use java.net.Proxy.NO_PROXY as a default.

Acconut commented 1 year ago

Yes, of course! Feel free to open a PR for this.

pdenooijer commented 1 year ago

@Acconut we could fix this pretty quickly and robust. Would you be open to review the code (provided we create a PR), merge it (after comments are resolved) and create a new release? The lack of this feature is blocking our implementation. We're behind a proxy for external connections, but don't want to use it for all request as most of them are local.

As said in https://github.com/tus/tus-java-client/issues/52#issuecomment-1456366427.

Acconut commented 1 year ago

Yes, sure. We are always happy to accept PRs.

piotrblasiak commented 8 months ago

Any ETA on this? This library is currently unusable with cloudflare because of the HTTP client apparently.

Acconut commented 8 months ago

No ETA, but we will bump it up on our priority list.