search

tus / tus-node-server

Node.js tus server, standalone or integrable in any framework, with disk, S3, Azure, and GGC stores.
https://tus.io/
MIT License
824 stars 201 forks source link

@s3/store: Allow disabling tagging on expiration extension #553

Closed fenos closed 9 months ago

fenos commented 9 months ago

This PR fixes #538 introduces a new option useTags which will allow disabling tagging objects for S3 providers who don't support them.

Tags will be now used only if the expiration extension is used.

rougsig commented 9 months ago

Will expiration extension work if tagging disabled?

If not, may be it's better to disable extension from options?

fenos commented 9 months ago

@rougsig yes, the expiration extension will still work if the tagging is disabled.

However, you won't be able to use lifecycle rules to clean up files automatically. See: S3 Expiration

You will have to call server.cleanUpExpiredUploads() in a cron-job yourself.