tus / tus-node-server

Node.js tus server, standalone or integrable in any framework, with disk, S3, Azure, and GGC stores.
https://tus.io/
MIT License
824 stars 201 forks source link

Introduce @tus/utils to simplify building/publishing #567

Closed Murderlon closed 9 months ago

Murderlon commented 9 months ago

Problems:

Solution:

Now we have correct dependency graphs for turbo and we can publish more correctly and easily with changesets.

This is arguably a breaking change, but I'd argue it isn't. It only is if you update one package but not the other. However that can happen all time the time in monorepo setups like this. Whether it's a bug fix that is coordinated between packages, or a feature that needs detecting in a store, you can't expect all changes to work if you don't upgrade packages together. In Uppy, our policy is it's not a breaking change if we don't change exports and no public methods and properties a are changed.

Acconut commented 9 months ago

I don't understand how @tus/utils helps with the peerDependencies issue. Can you elaborate on this? Or is not addressed by this PR?

Murderlon commented 9 months ago

As seen in the diff, there are no peer dependencies anymore and thus no problems anymore associated with them. All packages now have @tus/utils in dependencies. Similar to how this was solved in Uppy with @uppy/utils.