search

tus / tus-node-server

Node.js tus server, standalone or integrable in any framework, with disk, S3, and GGC stores.
https://tus.io/
MIT License
803 stars 197 forks source link

fix: allow lockDrainTimeout to be configurable #583

Closed fenos closed 4 months ago

fenos commented 7 months ago

This PR simply allows customizing the lockDrainTimeout option.

When a request gets canceled by another lock, this option allow the cancelled request to wait until the lockDrainTimeout before starting the shutdown procedure, this is useful when we want to give a bit more time to a request to try and finish gracefully.

On the cancelling side, the lock will be held for this same period

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: db6ce2dfa140b328108355f7d06c02305c0f0813

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Murderlon commented 6 months ago

Want to get this over the finish line soon? I would do it myself but I don't have access to push to this PR.