search

tus / tus-py-client

A Python client for the tus resumable upload protocol
https://tus.io/
MIT License
167 stars 45 forks source link

Provide a requests session to Uploader [Feature Request] #77

Open peterroelants opened 1 year ago

peterroelants commented 1 year ago

It would make the library more flexible if the Uploader could be given a requests Session object which it uses to make all requests.

Custom requests sessions can be used for many things. For example, I use them myself to capture all 401 Unauthorized errors when my tokens are expired, make sure I'm re-authenticated and repeat the request. I've seen others use them to fix a URL base or adding custom headers.

Would tus-py-client maintainers be open to providing the ability to initialize an Uploader with a custom requests.Session object to enable use cases like this?

peterroelants commented 1 year ago

Maybe it is not clear from the initial comment, but I would be willing to spend time myself implementing the feature, if you think it would be a good idea.

Acconut commented 1 year ago

Sounds good! It will be great if you could open a PR for this!

SpecLad commented 1 year ago

It would be handy if there was a way to provide a custom HTTP stack, like in tus-js-client.